Skip to content

Use workspace:^ for all internal workspace dependencies#804

Merged
KetanReddy merged 5 commits intomainfrom
copilot/better-package-json-management
Mar 23, 2026
Merged

Use workspace:^ for all internal workspace dependencies#804
KetanReddy merged 5 commits intomainfrom
copilot/better-package-json-management

Conversation

Copy link
Contributor

Copilot AI commented Feb 20, 2026

Currently all @player-ui/* workspace references use workspace:*, which pnpm replaces with exact versions on publish (e.g. 1.0.0). This pins consumers to specific patch versions unnecessarily and breaks scenarios where not every package is bumped simultaneously.

Changes

  • All 37 workspace package.json files — replaced workspace:*workspace:^ across dependencies, devDependencies, and peerDependencies

Result

Published packages will now carry semver ranges instead of pinned versions:

// Before
{
  "dependencies": { "@player-ui/partial-match-registry": "1.0.0" },
  "peerDependencies": { "@player-ui/player": "1.0.0", "@player-ui/types": "1.0.0" }
}

// After
{
  "dependencies": { "@player-ui/partial-match-registry": "^1.0.0" },
  "peerDependencies": { "@player-ui/player": "^1.0.0", "@player-ui/types": "^1.0.0" }
}

This lets package managers resolve compatible versions correctly when consumers haven't bumped every @player-ui/* package.

Release Notes

Update core/react packages to use use peer versions for all internal player dependencies.

… on publish

Co-authored-by: adierkens <13004162+adierkens@users.noreply.github.com>
Copilot AI changed the title [WIP] Update package.json for better version management in 1.0 Use workspace:^ for all internal workspace dependencies Feb 20, 2026
@codecov
Copy link

codecov bot commented Feb 20, 2026

Bundle Report

Bundle size has no change ✅

@KetanReddy
Copy link
Member

Are there certain cases where we would want to make sure that the versions are the same? I know on the react player side we've seen issues with mismatched versions causing react context issues.

@KetanReddy KetanReddy marked this pull request as ready for review March 12, 2026 02:03
@KetanReddy KetanReddy requested review from a team as code owners March 12, 2026 02:03
@KetanReddy KetanReddy enabled auto-merge March 12, 2026 02:03
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (e3244f5) to head (c07ce0e).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #804   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spentacular spentacular disabled auto-merge March 14, 2026 04:38
@KetanReddy KetanReddy added the skip-release Preserve the current version when merged label Mar 20, 2026
@KetanReddy KetanReddy merged commit eeda2d8 into main Mar 23, 2026
16 checks passed
@KetanReddy KetanReddy deleted the copilot/better-package-json-management branch March 23, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release Preserve the current version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants